Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(crons): Give Monitor.type a db_default #88481

Merged
merged 2 commits into from
Apr 1, 2025
Merged

ref(crons): Give Monitor.type a db_default #88481

merged 2 commits into from
Apr 1, 2025

Conversation

evanpurkhiser
Copy link
Member

We'll be removing this column

@evanpurkhiser
ref(crons): Give Monitor.type a db_default
61b375a 
We'll be removing this column
@evanpurkhiser evanpurkhiser requested review from a team as code owners April 1, 2025 19:54
@evanpurkhiser evanpurkhiser removed the request for review from a team April 1, 2025 19:54
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) April 1, 2025 19:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0855_give_monitor_type_a_db_default.py ()

--
-- Alter field type on monitor
--
ALTER TABLE "sentry_monitor" ALTER COLUMN "type" SET DEFAULT 0;

@evanpurkhiser evanpurkhiser requested a review from a team April 1, 2025 20:11
@evanpurkhiser evanpurkhiser merged commit 8ec3692 into master Apr 1, 2025
48 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-give-monitor-type-a-db-default branch April 1, 2025 21:06
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@evanpurkhiser @andrewshie-sentry
ref(crons): Give Monitor.type a db_default (#88481)
6232781 
We'll be removing this column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @wedamija