issues: fix alert panel #88479
Merged
issues: fix alert panel #88479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -400,8 +401,8 @@ function IssueListActions({ | |||
| onSelectStatsPeriod={onSelectStatsPeriod} | |||
| /> | |||
| {!allResultsVisible && pageSelected && ( | |||
| <StyledAlert type="warning" system> | |||
| <SelectAllNotice data-test-id="issue-list-select-all-notice"> | |||
| <Alert system type="warning"> | |||
There was a problem hiding this comment.
hmm, the system usage feels wrong here, shouldn't we just be using a panelAlert here?
There was a problem hiding this comment.
PanelAlert is just Alert with system on it :)
const PanelAlert = styled((props: Omit<AlertProps, 'system' | 'showIcon'>) => (
<Alert.Container>
<Alert {...props} showIcon system />
</Alert.Container>
))`There was a problem hiding this comment.
I dont think we want the icon in this case, as it'll show the Warning Icon. This entire thing is more of a callout than an actual alert. It probably would have been better to have a pattern next to the checkbox for this. A dropdown with bulk actions might be preferable tbqh
There was a problem hiding this comment.
yeah this whole thing just sort of feels semantically wrong
evanpurkhiser
approved these changes
Apr 1, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Before  After 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
