Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grouping-settings): Show super user the derived grouping enhancements information #88475

Merged
merged 6 commits into from
Apr 2, 2025

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Apr 1, 2025

This will help if we need to debug automatically derived in-app stack trace rules.
This will only show when the user is signed in as a superuser.

image

@armenzg armenzg self-assigned this Apr 1, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025
@armenzg armenzg requested a review from a team April 1, 2025 19:04
@armenzg armenzg marked this pull request as draft April 1, 2025 19:06
armenzg added 3 commits April 1, 2025 15:08
This will help if we need to debug automatically derived in-app stack trace rules.
@armenzg armenzg force-pushed the feat/ui/show_option/auto_source/armenzg branch from eccf562 to 9ac41fd Compare April 1, 2025 20:19
Copy link

codecov bot commented Apr 1, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10084 1 10083 5
View the top 1 failed test(s) by shortest run time
projectIssueGrouping shows derived grouping enhancements only for superusers
Stack Traces | 0.074s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

An update to Access inside a test was not wrapped in act(...).

When testing, code that causes React state updates should be wrapped into act(...):

act(() => {
  /* fire events that update state */
});
/* assert on the output */

This ensures that you're testing the behavior the user would see in the browser. Learn more at https://react.dev/link/wrap-tests-with-act
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at .../react-dom/cjs/react-dom-client.development.js:15751:19
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at warnIfUpdatesNotWrappedWithActDEV (.../react-dom/cjs/react-dom-client.development.js:15750:9)
    at scheduleUpdateOnFiber (.../react-dom/cjs/react-dom-client.development.js:14311:11)
    at forceStoreRerender (.../react-dom/cjs/react-dom-client.development.js:6349:24)
    at Store.<anonymous> (.../react-dom/cjs/react-dom-client.development.js:6334:41)
    at EventEmitter.eventHandler (.../reflux-core/lib/PublisherMethods.js:44:22)
    at EventEmitter.emit (.../node_modules/eventemitter3/index.js:116:35)
    at Store.trigger (.../reflux-core/lib/PublisherMethods.js:63:26)
    at Store.set (.../app/stores/configStore.tsx:28:10)
    at Object.<anonymous> (.../settings/projectIssueGrouping/index.spec.tsx:67:26)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@armenzg armenzg changed the title feat(grouping-settings): Show staff the derived grouping enhancements feat(grouping-settings): Show super user the derived grouping enhancements information Apr 1, 2025
@armenzg armenzg requested a review from scttcper April 1, 2025 20:27
@armenzg armenzg marked this pull request as ready for review April 1, 2025 20:28
@armenzg armenzg merged commit 36034c2 into master Apr 2, 2025
40 checks passed
@armenzg armenzg deleted the feat/ui/show_option/auto_source/armenzg branch April 2, 2025 12:05
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
…ments information (#88475)

This will help if we need to debug automatically derived in-app stack
trace rules.
This will only show when the user is signed in as a superuser.

<img width="473" alt="image"
src="https://github.com/user-attachments/assets/eca8e2ea-4f7c-4fe6-9217-93bbc9259e3b"
/>

---------

Co-authored-by: Scott Cooper <[email protected]>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
armenzg added a commit that referenced this pull request Apr 10, 2025
In #88475 we added the modal but never made it read-only.
armenzg added a commit that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants