🔧 chore(aci): loosen sentry app config schema #88474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88474 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 10009 10009
Lines 566807 566863 +56
Branches 22270 22270
=======================================
+ Hits 497403 497453 +50
- Misses 68985 68991 +6
Partials 419 419 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
when @mifu67 ran dry runs for the metric alert migration - we found that we saved a couple sentry_config `value` keys as `None`, when they shouldn't be. the hunch is that it is because the user unset a form value at some point in time, and instead of removing the key, we set it to be None. wrote a test to verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when @mifu67 ran dry runs for the metric alert migration - we found that we saved a couple sentry_config
valuekeys asNone, when they shouldn't be. the hunch is that it is because the user unset a form value at some point in time, and instead of removing the key, we set it to be None.wrote a test to verify