Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tours): Avoid conflicting guides on issue details #88471

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

leeandher
Copy link
Member

The legacy tour overlapped with the new one in a few places. This PR addresses that:

  1. If a new component is used on the streamline UI, delete the GuideAnchor
  2. If they use the same component, disable the GuideAnchor with the streamline UI flag

I went and did this for all the guide anchors in the current issue tour, found here https://github.com/getsentry/sentry/blob/master/static/app/components/assistant/getGuidesContent.tsx#L17

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025
@leeandher leeandher marked this pull request as ready for review April 1, 2025 18:50
@leeandher leeandher requested a review from a team as a code owner April 1, 2025 18:50
@leeandher leeandher enabled auto-merge (squash) April 1, 2025 18:57
@leeandher leeandher merged commit 0f6ee24 into master Apr 1, 2025
41 checks passed
@leeandher leeandher deleted the leander/disable-legacy-tour-in-streamline branch April 1, 2025 19:03
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
The legacy tour overlapped with the new one in a few places. This PR
addresses that:

1. If a new component is used on the streamline UI, delete the
GuideAnchor
2. If they use the same component, disable the GuideAnchor with the
streamline UI flag

I went and did this for all the guide anchors in the current issue tour,
found here
https://github.com/getsentry/sentry/blob/master/static/app/components/assistant/getGuidesContent.tsx#L17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants