ref(span-buffer): Reduce zadd/zrem calls to Redis #88463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build up a bunch of temporary datastructures in Python to relieve load on Redis. The result is more CPU usage in consumers but that might be worth it.
jan-auer
approved these changes
Apr 2, 2025
| p.expire(key, self.redis_ttl) | ||
| has_root_span_count = 0 | ||
| min_hole_size = float("inf") | ||
| max_hole_size = float("-inf") |
There was a problem hiding this comment.
Note I'm renaming these in #88453, so we will need to resolve a conflict there.
|
|
||
| assert len(queue_keys) == len(results) | ||
|
|
||
| for queue_key, (hole_size, delete_item, add_item, has_root_span) in zip( |
There was a problem hiding this comment.
nit: Can we type the redis script result and then pass the queue part through a sub-function for readability?
Hole size can be iterated and logged entirely separately from the remaining result.
There was a problem hiding this comment.
discussed offline, let's keep as-is due to unrelated metrics being recorded in this loop
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Build up a bunch of temporary datastructures in Python to relieve load on Redis. The result is more CPU usage in consumers but that might be worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build up a bunch of temporary datastructures in Python to relieve load
on Redis. The result is more CPU usage in consumers but that might be
worth it.