feat(insights): use epm instead of spm everywhere in frontend #88452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏻 small post-merge question! Since EAP includes other trace items (like logs), do we need to audit all our queries to make sure they filter to just spans somehow, or no? |
@gggritso nope! You still can only query for one type at a time, this will be controlled by the dataset parameter in the events endpoint(dataset=spans, dataset=logs, etc). I think we'll keep this behaviour, maybe eventually we'll have dataset=any, but I doubt we'll remove dataset=spans,logs, etc |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
spm will not be in eap. Instead epm will be provided because it is more generic. This PR switches everything to `epm` as it's available in both eap and span metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spm will not be in eap. Instead epm will be provided because it is more generic. This PR switches everything to
epmas it's available in both eap and span metrics