fix(js): Fix key warning in Hook component #88450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +53,9 @@ function Hook<H extends HookName>({name, ...props}: Props<H>) { | |||
| return; | |||
| } | |||
|
|
|||
| this.setState({hooks: hooks.map(cb => cb(props))}); | |||
There was a problem hiding this comment.
is it always a component?
There was a problem hiding this comment.
Hmm I figured that the point of this was to render getsentry components so I hope so. Maybe I can get the types to validate that
There was a problem hiding this comment.
Okay added some type checking, looks like all the current usages are indeed components.
static/app/components/hook.tsx
Outdated
Comment on lines
6
to
9
| // Only allow hooks that return a React component | ||
| type ComponentHookName = { | ||
| [K in HookName]: Hooks[K] extends React.ComponentType<any> ? K : never; | ||
| }[HookName]; |
evanpurkhiser
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing console errors in dev anywhere that the
<Hook />component was being used to render a getsentry component.