Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace-eap-waterfall): Rendering orphan errors from new eap endpoint #88444

Merged
merged 7 commits into from
Apr 3, 2025

Conversation

Abdkhan14
Copy link
Contributor

@Abdkhan14 Abdkhan14 commented Apr 1, 2025

The goal of the PR is to support rendering an individual row for orphan errors (type below), in the trace waterfall:

type EAPError = {
  event_id: string;
  event_type: string;
  issue_id: number;
  level: Level;
  project_id: number;
  project_slug: string;
  start_timestamp: number;
  transaction: string;
  description?: string;
};

Bulk of the PR involves using guards to ensure feature parity with other event types already existing in the waterfall.

Added tests.

Base automatically changed from abdk/trace-eap-waterfall-errors to master April 1, 2025 15:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
10068 2 10066 5
View the top 2 failed test(s) by shortest run time
trace view pageload scrolls to trace error node
Stack Traces | 0.543s run time
Error: expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:988:61)
EventTraceView renders a trace
Stack Traces | 1.47s run time
Error: Unable to find an element with the text: MaybeEncodingError: Error sending result. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../interfaces/performance/eventTraceView.spec.tsx:119:46)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Abdkhan14 Abdkhan14 marked this pull request as ready for review April 1, 2025 18:25
@Abdkhan14 Abdkhan14 requested review from a team as code owners April 1, 2025 18:25
@Abdkhan14 Abdkhan14 merged commit 20bec4a into master Apr 3, 2025
40 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-eap-orphan-errors branch April 3, 2025 17:52
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
…int (#88444)

The goal of the PR is to support rendering an individual row for orphan
errors (type below), in the trace waterfall:

```
type EAPError = {
  event_id: string;
  event_type: string;
  issue_id: number;
  level: Level;
  project_id: number;
  project_slug: string;
  start_timestamp: number;
  transaction: string;
  description?: string;
};
```
Bulk of the PR involves using guards to ensure feature parity with other
event types already existing in the waterfall.

Added tests.

---------

Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants