icons: use named export #88441

JonasBa · 2025-04-01T14:48:05Z

No description provided.

codecov · 2025-04-01T14:52:14Z

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
10065	5	10060	5

View the top 3 failed test(s) by shortest run time

IntegrationDetailedView allows members to configure github/gitlab

Stack Traces | 0.052s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

ReferenceError: ICON_PATHS is not defined
    at ImageIcon (.../settings/organizationIntegrations/integrationIcon.tsx:16:24)
    at Object.react-stack-bottom-frame (.../react-dom/cjs/react-dom-client.development.js:22428:20)
    at renderWithHooks (.../react-dom/cjs/react-dom-client.development.js:5757:22)
    at updateFunctionComponent (.../react-dom/cjs/react-dom-client.development.js:8018:19)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9683:18)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14384:44)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous>.process.env.NODE_ENV.reportGlobalError (.../react-dom/cjs/react-dom-client.development.js:23837:23)
    at defaultOnUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7398:7)
    at logUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7469:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at lane.callback (.../react-dom/cjs/react-dom-client.development.js:7499:9)
    at callCallback (.../react-dom/cjs/react-dom-client.development.js:10680:16)
    at commitCallbacks (.../react-dom/cjs/react-dom-client.development.js:10700:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at commitLayoutEffectOnFiber (.../react-dom/cjs/react-dom-client.development.js:11511:15)
    at commitLayoutEffects (.../react-dom/cjs/react-dom-client.development.js:12406:7)
    at commitRootImpl (.../react-dom/cjs/react-dom-client.development.js:15352:11)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:15251:11)
    at commitRootWhenReady (.../react-dom/cjs/react-dom-client.development.js:14570:7)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14494:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

IntegrationDetailedView disables configure for members without access

Stack Traces | 0.056s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

ReferenceError: ICON_PATHS is not defined
    at ImageIcon (.../settings/organizationIntegrations/integrationIcon.tsx:16:24)
    at Object.react-stack-bottom-frame (.../react-dom/cjs/react-dom-client.development.js:22428:20)
    at renderWithHooks (.../react-dom/cjs/react-dom-client.development.js:5757:22)
    at updateFunctionComponent (.../react-dom/cjs/react-dom-client.development.js:8018:19)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9683:18)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14384:44)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous>.process.env.NODE_ENV.reportGlobalError (.../react-dom/cjs/react-dom-client.development.js:23837:23)
    at defaultOnUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7398:7)
    at logUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7469:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at lane.callback (.../react-dom/cjs/react-dom-client.development.js:7499:9)
    at callCallback (.../react-dom/cjs/react-dom-client.development.js:10680:16)
    at commitCallbacks (.../react-dom/cjs/react-dom-client.development.js:10700:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at commitLayoutEffectOnFiber (.../react-dom/cjs/react-dom-client.development.js:11511:15)
    at commitLayoutEffects (.../react-dom/cjs/react-dom-client.development.js:12406:7)
    at commitRootImpl (.../react-dom/cjs/react-dom-client.development.js:15352:11)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:15251:11)
    at commitRootWhenReady (.../react-dom/cjs/react-dom-client.development.js:14570:7)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14494:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

ContextPickerModal isSuperUser and selects an integrationConfig and calls `onFinish` with URL to that configuration

Stack Traces | 0.097s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

ReferenceError: ICON_PATHS is not defined
    at ImageIcon (.../settings/organizationIntegrations/integrationIcon.tsx:16:24)
    at Object.react-stack-bottom-frame (.../react-dom/cjs/react-dom-client.development.js:22428:20)
    at renderWithHooks (.../react-dom/cjs/react-dom-client.development.js:5757:22)
    at updateFunctionComponent (.../react-dom/cjs/react-dom-client.development.js:8018:19)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9683:18)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14384:44)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous>.process.env.NODE_ENV.reportGlobalError (.../react-dom/cjs/react-dom-client.development.js:23837:23)
    at defaultOnUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7398:7)
    at logUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7469:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at lane.callback (.../react-dom/cjs/react-dom-client.development.js:7499:9)
    at callCallback (.../react-dom/cjs/react-dom-client.development.js:10680:16)
    at commitCallbacks (.../react-dom/cjs/react-dom-client.development.js:10700:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at commitLayoutEffectOnFiber (.../react-dom/cjs/react-dom-client.development.js:11511:15)
    at commitLayoutEffects (.../react-dom/cjs/react-dom-client.development.js:12406:7)
    at commitRootImpl (.../react-dom/cjs/react-dom-client.development.js:15352:11)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:15251:11)
    at commitRootWhenReady (.../react-dom/cjs/react-dom-client.development.js:14570:7)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14494:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

JonasBa added 7 commits April 1, 2025 10:13

icons: fix type and placeholder

e11a63c

icons: cleanup type

b1d5a95

icons: make the provider a required prop

7061e58

icons: export identity icon props

0b7c937

icons: providerid has no default initializer

0aef8a8

icons: fix type

b31b4cd

icons: use placeholder

cc4badb

JonasBa requested review from a team as code owners April 1, 2025 14:48

evanpurkhiser approved these changes Apr 1, 2025

View reviewed changes

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025

vercel bot deployed to Preview April 1, 2025 14:51 View deployment

JonasBa added 4 commits April 1, 2025 10:52

icons: fix image fallback rendering

53c4df4

icons: add icon stories

5875103

icons: rename to imageicon

00719a0

icons: use array and fix import

4dc2e24

JonasBa force-pushed the jb/icons/pluginicon-stories branch from 8756531 to 4dc2e24 Compare April 1, 2025 14:53

JonasBa added 3 commits April 1, 2025 10:54

icons: use named export for pluginIcon

869b591

icons: use named export for pluginIcon

5829ac7

icons: use named export for identityicon and ingegrationicon

07d1d3c

JonasBa force-pushed the jb/icons/named-exports branch from e240b42 to 07d1d3c Compare April 1, 2025 14:54

vercel bot deployed to Preview April 1, 2025 14:58 View deployment

Base automatically changed from jb/icons/pluginicon-stories to master April 1, 2025 15:43

Merge branch 'master' into jb/icons/named-exports

66c1c5a

vercel bot deployed to Preview April 1, 2025 18:01 View deployment

JonasBa merged commit 99d59f1 into master Apr 1, 2025
40 checks passed

JonasBa deleted the jb/icons/named-exports branch April 1, 2025 18:19

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025

icons: use named export (#88441)

c71ecf9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

icons: use named export #88441

icons: use named export #88441

JonasBa commented Apr 1, 2025

codecov bot commented Apr 1, 2025 •

edited

Loading

icons: use named export #88441

icons: use named export #88441

Conversation

JonasBa commented Apr 1, 2025

codecov bot commented Apr 1, 2025 • edited Loading

❌ 5 Tests Failed:

codecov bot commented Apr 1, 2025 •

edited

Loading