feat(auto_source_config): Do not process categorized frames #88440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A developer may clone an Android sample app, thus, we can end up creating a code mapping and stack trace rule for it. This change prevents attempting to create code mappings and stack trace rules for frames we have already categorized with our internal rules. In other words, only non-categorized frames will be attempted.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88440 +/- ##
===========================================
+ Coverage 71.28% 87.72% +16.43%
===========================================
Files 10000 10002 +2
Lines 566438 566609 +171
Branches 22257 22257
===========================================
+ Hits 403800 497069 +93269
+ Misses 162220 69122 -93098
Partials 418 418 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
A developer may clone an Android sample app, thus, we can end up creating a code mapping and stack trace rule for it. This change prevents attempting to create code mappings and stack trace rules for frames we have already categorized with our internal rules. In other words, only non-categorized frames will be attempted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A developer may clone an Android sample app, thus, we can end up creating a code mapping and stack trace rule for it.
This change prevents attempting to create code mappings and stack trace rules for frames we have already categorized with our internal rules.
In other words, only non-categorized frames will be attempted.