icons: add icon stories #88438

JonasBa · 2025-04-01T14:38:37Z

Add stories for <PluginIcon/> and <IntegrationIcon/>

codecov · 2025-04-01T14:48:43Z

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
10066	5	10061	5

View the top 3 failed test(s) by shortest run time

IntegrationDetailedView disables configure for members without access

Stack Traces | 0.053s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

ReferenceError: ImageIcon is not defined
    at IntegrationIcon (.../settings/organizationIntegrations/integrationIcon.tsx:30:50)
    at Object.react-stack-bottom-frame (.../react-dom/cjs/react-dom-client.development.js:22428:20)
    at renderWithHooks (.../react-dom/cjs/react-dom-client.development.js:5757:22)
    at updateFunctionComponent (.../react-dom/cjs/react-dom-client.development.js:8018:19)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9683:18)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14384:44)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous>.process.env.NODE_ENV.reportGlobalError (.../react-dom/cjs/react-dom-client.development.js:23837:23)
    at defaultOnUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7398:7)
    at logUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7469:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at lane.callback (.../react-dom/cjs/react-dom-client.development.js:7499:9)
    at callCallback (.../react-dom/cjs/react-dom-client.development.js:10680:16)
    at commitCallbacks (.../react-dom/cjs/react-dom-client.development.js:10700:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at commitLayoutEffectOnFiber (.../react-dom/cjs/react-dom-client.development.js:11511:15)
    at commitLayoutEffects (.../react-dom/cjs/react-dom-client.development.js:12406:7)
    at commitRootImpl (.../react-dom/cjs/react-dom-client.development.js:15352:11)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:15251:11)
    at commitRootWhenReady (.../react-dom/cjs/react-dom-client.development.js:14570:7)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14494:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

IntegrationDetailedView allows members to configure github/gitlab

Stack Traces | 0.083s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

ReferenceError: ImageIcon is not defined
    at IntegrationIcon (.../settings/organizationIntegrations/integrationIcon.tsx:30:50)
    at Object.react-stack-bottom-frame (.../react-dom/cjs/react-dom-client.development.js:22428:20)
    at renderWithHooks (.../react-dom/cjs/react-dom-client.development.js:5757:22)
    at updateFunctionComponent (.../react-dom/cjs/react-dom-client.development.js:8018:19)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9683:18)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14384:44)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous>.process.env.NODE_ENV.reportGlobalError (.../react-dom/cjs/react-dom-client.development.js:23837:23)
    at defaultOnUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7398:7)
    at logUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7469:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at lane.callback (.../react-dom/cjs/react-dom-client.development.js:7499:9)
    at callCallback (.../react-dom/cjs/react-dom-client.development.js:10680:16)
    at commitCallbacks (.../react-dom/cjs/react-dom-client.development.js:10700:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at commitLayoutEffectOnFiber (.../react-dom/cjs/react-dom-client.development.js:11511:15)
    at commitLayoutEffects (.../react-dom/cjs/react-dom-client.development.js:12406:7)
    at commitRootImpl (.../react-dom/cjs/react-dom-client.development.js:15352:11)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:15251:11)
    at commitRootWhenReady (.../react-dom/cjs/react-dom-client.development.js:14570:7)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14494:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

ContextPickerModal isSuperUser and selects an integrationConfig and calls `onFinish` with URL to that configuration

Stack Traces | 0.09s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

ReferenceError: ImageIcon is not defined
    at IntegrationIcon (.../settings/organizationIntegrations/integrationIcon.tsx:30:50)
    at Object.react-stack-bottom-frame (.../react-dom/cjs/react-dom-client.development.js:22428:20)
    at renderWithHooks (.../react-dom/cjs/react-dom-client.development.js:5757:22)
    at updateFunctionComponent (.../react-dom/cjs/react-dom-client.development.js:8018:19)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9683:18)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14384:44)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous>.process.env.NODE_ENV.reportGlobalError (.../react-dom/cjs/react-dom-client.development.js:23837:23)
    at defaultOnUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7398:7)
    at logUncaughtError (.../react-dom/cjs/react-dom-client.development.js:7469:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at lane.callback (.../react-dom/cjs/react-dom-client.development.js:7499:9)
    at callCallback (.../react-dom/cjs/react-dom-client.development.js:10680:16)
    at commitCallbacks (.../react-dom/cjs/react-dom-client.development.js:10700:11)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at commitLayoutEffectOnFiber (.../react-dom/cjs/react-dom-client.development.js:11511:15)
    at commitLayoutEffects (.../react-dom/cjs/react-dom-client.development.js:12406:7)
    at commitRootImpl (.../react-dom/cjs/react-dom-client.development.js:15352:11)
    at commitRoot (.../react-dom/cjs/react-dom-client.development.js:15251:11)
    at commitRootWhenReady (.../react-dom/cjs/react-dom-client.development.js:14570:7)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14494:15)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

Add stories for `<PluginIcon/>` and `<IntegrationIcon/>`

JonasBa added 5 commits April 1, 2025 10:13

icons: fix type and placeholder

e11a63c

icons: cleanup type

b1d5a95

icons: make the provider a required prop

7061e58

icons: export identity icon props

0b7c937

icons: providerid has no default initializer

0aef8a8

JonasBa requested a review from a team as a code owner April 1, 2025 14:38

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025

vercel bot deployed to Preview April 1, 2025 14:39 View deployment

icons: fix type

b31b4cd

JonasBa force-pushed the jb/icons/pluginicon-stories branch from 5c47fdb to 1dd5d41 Compare April 1, 2025 14:42

icons: use placeholder

cc4badb

JonasBa force-pushed the jb/icons/pluginicon-stories branch from 1dd5d41 to 8756531 Compare April 1, 2025 14:44

vercel bot deployed to Preview April 1, 2025 14:50 View deployment

JonasBa added 4 commits April 1, 2025 10:52

icons: fix image fallback rendering

53c4df4

icons: add icon stories

5875103

icons: rename to imageicon

00719a0

icons: use array and fix import

4dc2e24

JonasBa force-pushed the jb/icons/pluginicon-stories branch from 8756531 to 4dc2e24 Compare April 1, 2025 14:53

evanpurkhiser approved these changes Apr 1, 2025

View reviewed changes

vercel bot deployed to Preview April 1, 2025 14:58 View deployment

Base automatically changed from jb/icons/cleanup to master April 1, 2025 15:18

Merge branch 'master' into jb/icons/pluginicon-stories

551b02f

vercel bot deployed to Preview April 1, 2025 15:23 View deployment

icons: fix bad merge

cf3d9e2

vercel bot deployed to Preview April 1, 2025 15:32 View deployment

JonasBa enabled auto-merge (squash) April 1, 2025 15:40

JonasBa merged commit 6d5820a into master Apr 1, 2025
40 checks passed

JonasBa deleted the jb/icons/pluginicon-stories branch April 1, 2025 15:43

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025

icons: add icon stories (#88438)

a1dc511

Add stories for `<PluginIcon/>` and `<IntegrationIcon/>`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

icons: add icon stories #88438

icons: add icon stories #88438

JonasBa commented Apr 1, 2025 •

edited

Loading

codecov bot commented Apr 1, 2025 •

edited

Loading

icons: add icon stories #88438

icons: add icon stories #88438

Conversation

JonasBa commented Apr 1, 2025 • edited Loading

codecov bot commented Apr 1, 2025 • edited Loading

❌ 5 Tests Failed:

JonasBa commented Apr 1, 2025 •

edited

Loading

codecov bot commented Apr 1, 2025 •

edited

Loading