ref(types): improve types of exported fields with satisfies #88417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satisfies makes sure we adhere to a certain structure (in this case, Record<string, Field>), but it will still infer the type from what we have actually defined. In this case, this means that it won't be a Record with an index signature, but it will rather know about the names of the defined fields. That makes sure we can access fields without doing a non-null assertion (!)
JonasBa
approved these changes
Apr 1, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
satisfies makes sure we adhere to a certain structure (in this case, Record<string, Field>), but it will still infer the type from what we have actually defined. In this case, this means that it won't be a Record with an index signature, but it will rather know about the names of the defined fields. That makes sure we can access fields without doing a non-null assertion (!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
satisfies makes sure we adhere to a certain structure (in this case, Record<string, Field>), but it will still infer the type from what we have actually defined.
In this case, this means that it won't be a Record with an index signature, but it will rather know about the names of the defined fields. That makes sure we can access fields without doing a non-null assertion (!)