🔧 chore: fix tests for ai issue summary in slack to prevent feature flag pollution #88408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…lag pollution (#88408) updating the tests for slack ai issue summary so we don't mock feature flag checks. broke down the tests in the 2 cases where the feature flags are enabled and disabled when we mock feature flag checks, we are susceptible to feature flag pollution where we end up not evaluating feature flags correctly and `with_feature` doesn't work as its supposed to. ran into feature flag pollution in this pr: #88380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating the tests for slack ai issue summary so we don't mock feature flag checks. broke down the tests in the 2 cases where the feature flags are enabled and disabled
when we mock feature flag checks, we are susceptible to feature flag pollution where we end up not evaluating feature flags correctly and
with_featuredoesn't work as its supposed to.ran into feature flag pollution in this pr: #88380