Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(billing): Gifted profile hour subtext #88405

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

jarrettscott
Copy link
Contributor

@jarrettscott jarrettscott commented Mar 31, 2025

Closes: https://github.com/getsentry/getsentry/issues/17065

Removes the "0 Reserved" from the Profile Hour subtext when displaying the org's gifted units.

Before

Screenshot 2025-03-31 at 7 02 38 PM

After

Screenshot 2025-04-01 at 9 20 47 AM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2025
Copy link

codecov bot commented Mar 31, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
10065 3 10062 5
View the top 3 failed test(s) by shortest run time
formatReservedWithUnits returns correct string for Profile Duration
Stack Traces | 0.014s run time
Error: expect(received).toBe(expected) // Object.is equality

Expected: "1,000"
Received: "0.0002777777777777778"
    at Object.<anonymous> (.../gsApp/utils/billing.spec.tsx:108:94)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
Recurring Credits renders profile duration ui recurring credits
Stack Traces | 0.019s run time
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  +10/mo
Received:
  +0.000002777777777777778/mo
    at Object.<anonymous> (.../views/subscriptionPage/recurringCredits.spec.tsx:147:63)
Recurring Credits renders profile duration recurring credits
Stack Traces | 0.022s run time
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  +10/mo
Received:
  +0.000002777777777777778/mo
    at Object.<anonymous> (.../views/subscriptionPage/recurringCredits.spec.tsx:112:63)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@jarrettscott jarrettscott changed the title fix(billing): Profile hour unit conversion fix(billing): Gifted profile hour subtext Apr 1, 2025
@jarrettscott jarrettscott marked this pull request as ready for review April 1, 2025 16:33
@jarrettscott jarrettscott requested a review from a team as a code owner April 1, 2025 16:33
@jarrettscott jarrettscott merged commit 846e3d0 into master Apr 1, 2025
45 checks passed
@jarrettscott jarrettscott deleted the jarrett/profiling-subscription-unit-conversion branch April 1, 2025 17:52
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Closes: getsentry/getsentry#17065

Removes the "0 Reserved" from the Profile Hour subtext when displaying
the org's gifted units.

### Before

![Screenshot 2025-03-31 at 7 02
38 PM](https://github.com/user-attachments/assets/fa660d17-e136-4339-be8b-37ecb3d71ebd)

### After

<img width="406" alt="Screenshot 2025-04-01 at 9 20 47 AM"
src="https://github.com/user-attachments/assets/9404e362-31e0-4e40-bc6a-52fcd457ec42"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants