-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(ui): Upgrade react router v6.30.0 #88397
Conversation
Seems like it fixes the issue where going between issues stream and issue details multiple times does not scroll to the top of the page. https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v6300
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
// Force the router to update children | ||
rtl.act(() => newRouter.revalidate()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rerenders were broken without this piece. If anyone has other ideas i'm not sure why we needed this.
const handleDropdown = (value: any) => { | ||
const selected = options.find((option: any) => option.value === value); | ||
if (selected && component) { | ||
component.rerender( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this funky rerender self callback thing wasn't working anymore
https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v6300
turns on future flags in tests that are not yet enabled in production but it shouldn't be too crazy.