Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(ui): Upgrade react router v6.30.0 #88397

Merged
merged 4 commits into from
Apr 3, 2025
Merged

deps(ui): Upgrade react router v6.30.0 #88397

merged 4 commits into from
Apr 3, 2025

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Mar 31, 2025

https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v6300

turns on future flags in tests that are not yet enabled in production but it shouldn't be too crazy.

Seems like it fixes the issue where going between issues stream and issue details multiple times does not scroll to the top of the page.

https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v6300
@scttcper scttcper requested a review from a team March 31, 2025 21:52
@scttcper scttcper requested a review from a team as a code owner March 31, 2025 21:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2025
Copy link

codecov bot commented Mar 31, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
10086 2 10084 5
View the top 2 failed test(s) by shortest run time
EventGraph allows filtering by environment, and shows unfiltered stats
Stack Traces | 0.669s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: "....../organizations/org-slug/events-stats/", ObjectContaining {"query": ObjectContaining {"environment": ["production"]}}
Received: "....../organizations/org-slug/events-stats/", {"error": [Function error], "method": "GET", "query": {"cursor": undefined, "dataset": "errors", "environment": [], "field": ["title", "release", "environment", "user.display", "timestamp"], "interval": "4h", "partial": 1, "per_page": 50, "project": ["2"], "query": "issue:JAVASCRIPT-6QS", "referrer": "issue_details.streamline_graph", "statsPeriod": "14d", "yAxis": ["count()", "count_unique(user)"]}, "skipAbort": undefined, "success": [Function success]}

Number of calls: 1
    at Object.<anonymous> (.../issueDetails/streamline/eventGraph.spec.tsx:180:28)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
TransactionsList Basic allows users to change the sort in the dropdown
Stack Traces | 1.21s run time
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Array [
-   "/b",
-   "1000",
    "/a",
    "100",
+   "/b",
+   "1000",
  ]

Ignored nodes: comments, script, style
...
    at .../components/discover/transactionsList.spec.tsx:335:105
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scttcper scttcper requested a review from a team as a code owner April 2, 2025 23:27
@scttcper scttcper marked this pull request as draft April 2, 2025 23:27
Comment on lines +378 to +379
// Force the router to update children
rtl.act(() => newRouter.revalidate());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rerenders were broken without this piece. If anyone has other ideas i'm not sure why we needed this.

const handleDropdown = (value: any) => {
const selected = options.find((option: any) => option.value === value);
if (selected && component) {
component.rerender(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this funky rerender self callback thing wasn't working anymore

@scttcper scttcper marked this pull request as ready for review April 2, 2025 23:54
@scttcper scttcper requested a review from a team as a code owner April 2, 2025 23:54
@scttcper scttcper requested review from a team and michellewzhang April 2, 2025 23:54
@scttcper scttcper merged commit 68772a4 into master Apr 3, 2025
41 checks passed
@scttcper scttcper deleted the scttcper/router-6.3 branch April 3, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants