Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui2): display toast on theme change #88396

Merged
merged 3 commits into from
Apr 1, 2025
Merged

feat(ui2): display toast on theme change #88396

merged 3 commits into from
Apr 1, 2025

Conversation

natemoo-re
Copy link
Member

displays a toast when switching between default / UI2 theme

theme-toast.mov

@natemoo-re natemoo-re requested a review from a team as a code owner March 31, 2025 21:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2025
TkDodo
TkDodo approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Previewing UI2 theme”

should we get a proper name for the new theme?

@JonasBa
Copy link
Member

JonasBa commented Apr 1, 2025 •
edited
Loading

“Previewing UI2 theme”

should we get a proper name for the new theme?

How about previewing new theme or switched to new theme?

@natemoo-re natemoo-re enabled auto-merge (squash) April 1, 2025 15:53
@natemoo-re natemoo-re merged commit b2dbc8b into master Apr 1, 2025
40 checks passed
@natemoo-re natemoo-re deleted the ui2/nm/toast branch April 1, 2025 16:08
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@natemoo-re @andrewshie-sentry
feat(ui2): display toast on theme change (#88396)
0d4614c 
displays a toast when switching between default / UI2 theme


https://github.com/user-attachments/assets/2a158c3b-b68d-4e43-aa45-6cb3428f879d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natemoo-re @JonasBa @TkDodo