Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trace-eap-waterfall): Adding persistent toggle for trace format #88390

Merged
merged 2 commits into from
Apr 1, 2025
Merged

feat(trace-eap-waterfall): Adding persistent toggle for trace format #88390

merged 2 commits into from
Apr 1, 2025
+40 −31

Conversation

Abdkhan14
Copy link
Contributor

Initially it's set to NON-EAP.

Screenshot 2025-03-31 at 5 18 42 PM

@Abdkhan14 Abdkhan14 requested a review from wmak March 31, 2025 21:20
@Abdkhan14 Abdkhan14 requested review from a team as code owners March 31, 2025 21:20
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2025
@Abdkhan14 Abdkhan14 merged commit 34f4ff3 into master Apr 1, 2025
42 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-spans-format-toggle branch April 1, 2025 16:21
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@Abdkhan14 @andrewshie-sentry
feat(trace-eap-waterfall): Adding persistent toggle for trace format (#…
8040509 
…88390)

Initially it's set to `NON-EAP`.

<img width="1259" alt="Screenshot 2025-03-31 at 5 18 42 PM"
src="https://github.com/user-attachments/assets/4685518d-8aa0-4419-a527-74de5fef8a1c"
/>

---------

Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardgou-sentry edwardgou-sentry edwardgou-sentry approved these changes

@wmak wmak Awaiting requested review from wmak

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdkhan14 @edwardgou-sentry