feat(eap-spans): enable contexts in query for time series requests #88382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-working-in-timeseries-request
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88382 +/- ##
==========================================
+ Coverage 79.55% 87.73% +8.18%
==========================================
Files 10000 9998 -2
Lines 566501 566369 -132
Branches 22258 22244 -14
==========================================
+ Hits 450688 496926 +46238
+ Misses 112048 69020 -43028
+ Partials 3765 423 -3342 |
wmak
approved these changes
Mar 31, 2025
tests/snuba/api/endpoints/test_organization_events_stats_span_indexed.py
Show resolved
Hide resolved
…dain-137-spanmodule-not-working-in-timeseries-request
…dain-137-spanmodule-not-working-in-timeseries-request
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…88382) Allow contexts to be filtered on within time series requests, unfortunately because contexts can't be directly passed into the rpc (see getsentry/eap-planning#236), we have to do some funky remapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow contexts to be filtered on within time series requests, unfortunately because contexts can't be directly passed into the rpc (see https://github.com/getsentry/eap-planning/issues/236), we have to do some funky remapping