fix(ourlogs): Cleanup UI after aliasing changes #88379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also does some other cleanup: - Fully switch trace-items response type over from 'object' to 'array' since the backend has been out for a while - Fixes the log. aliases - Makes schema hints also be able to hide certain keys (some known fields of logs are internal and we don't want to expose them) - Adds a cell action for the body column on table (only body for now, the fieldrenderers need to be re-arranged before we do it for all of them, and they need tests first) - Fixes aliasing on sentry.project.id -> project_id since the backend fix will take a bit.
nikkikapadia
approved these changes
Apr 1, 2025
| @@ -36,6 +39,7 @@ interface SchemaHintsListProps extends SchemaHintsPageParams { | |||
| numberTags: TagCollection; | |||
| stringTags: TagCollection; | |||
| supportedAggregates: AggregationKey[]; | |||
| filterKeySections?: FilterKeySection[]; | |||
There was a problem hiding this comment.
I don't see this being used anywhere, can we get rid of it?
There was a problem hiding this comment.
Ah yeah, nice catch Nikki 👍
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
### Summary General cleanup after aliasing and other backend changes. Also adds a simple aliasing test for LogsFieldTree since we're doing a bunch of logic aside from rendering, we'll have to add a few more tests before we cleanup the field tree though. This also does some other cleanup: - Fully switch trace-items response type over from 'object' to 'array' since the backend has been out for a while - Fixes the log. aliases - Makes schema hints also be able to hide certain keys (some known fields of logs are internal and we don't want to expose them) - Adds a cell action for the body column on table (only body for now, the fieldrenderers need to be re-arranged before we do it for all of them, and they need tests first) - Fixes aliasing on sentry.project.id -> project_id since the backend fix will take a bit.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
General cleanup after aliasing and other backend changes. Also adds a simple aliasing test for LogsFieldTree since we're doing a bunch of logic aside from rendering, we'll have to add a few more tests before we cleanup the field tree though.
This also does some other cleanup: