chore(issues): Publish PUT method of OrganizationGroupIndexEndpoint
#88370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88370 +/- ##
===========================================
+ Coverage 33.09% 87.82% +54.73%
===========================================
Files 8465 10037 +1572
Lines 473001 568248 +95247
Branches 22301 22301
===========================================
+ Hits 156517 499061 +342544
+ Misses 316064 68767 -247297
Partials 420 420 |
0d5d585 to
a5b0fcd
Compare
e876b96 to
bda26a9
Compare
bda26a9 to
ecf5416
Compare
ecf5416 to
aa781aa
Compare
Unblocks #88370 Uses the latest version from sentry's pypi.
aa781aa to
05eacfb
Compare
|
CI is still broken, I'm going to double check that the fix actually works. |
7cd4681 to
bddde8f
Compare
| @@ -40,7 +40,7 @@ build-js-po: | |||
|
|
|||
| build-spectacular-docs: | |||
| @echo "--> Building drf-spectacular openapi spec (combines with deprecated docs)" | |||
| @OPENAPIGENERATE=1 sentry django spectacular --file tests/apidocs/openapi-spectacular.json --format openapi-json --validate --fail-on-warn | |||
| @OPENAPIGENERATE=1 sentry django spectacular --file tests/apidocs/openapi-spectacular.json --format openapi-json --validate | |||
There was a problem hiding this comment.
Doesn't feel great, but the warning about a duplicated enum is non addressable, since even adding it the ENUM_NAME_OVERRIDES key for DRF spectacular settings will then get removed because both choice lists hash to the same value, and then identifies them as a duplicate. This would be the only way to get around this.
There was a problem hiding this comment.
I believe this is discussed here, thought i may be misunderstanding tfranzel/drf-spectacular#790 (comment)
| @@ -1531,7 +1531,7 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]: | |||
| "PARSER_WHITELIST": ["rest_framework.parsers.JSONParser"], | |||
| "POSTPROCESSING_HOOKS": [ | |||
| "sentry.apidocs.hooks.custom_postprocessing_hook", | |||
| "drf_spectacular.hooks.postprocess_schema_enum_id_removal", | |||
| "drf_spectacular.hooks.postprocess_schema_enums", | |||
There was a problem hiding this comment.
This processing is necessary for the new endpoint to remove the null values from the enum being added, but also adds a lot more documentation to existing enum fields. The diff is too large to show all the changes though
Unblocks #88370 Uses the latest version from sentry's pypi.
Relates to #88127, where most of the work was done.
Requires #88459 because of the
allow_nullon thesubstatusserializers.ChoicesField. For context see tfranzel/drf-spectacular#235 (comment)Publishes the PUT method of the
OrganizationGroupIndexEndpoint