Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(billing): Use budgetTerm #88362

Merged
merged 4 commits into from
Apr 1, 2025
Merged

chore(billing): Use budgetTerm #88362

merged 4 commits into from
Apr 1, 2025

Conversation

isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Mar 31, 2025 •
edited
Loading

Follow up to https://github.com/getsentry/getsentry/pull/17051

This also updates over quota banner copy to be consistent across tiers (if over quota and user has billing perms, the CTA pushes them to setup/increase PAYG/OD). Prior to this PR, legacy customers would see the copy "Increase Reserved Limits" or "Update Plan" which should've taken them to checkout when it actually mistakenly took them to subscription settings with the open OD modal.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

❌ 27 Tests Failed:

Tests completed Failed Passed Skipped
10056 27 10029 5
View the top 3 failed test(s) by shortest run time 
Subscription > PendingChanges renders am1 plan and pending per-category ondemand changes
Stack Traces | 0.011s run time 
TestingLibraryElementError: Unable to find an element with the text: (_, node) => node?.nodeName === 'LI' && node.textContent === text. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at getItemWithText (.../views/subscriptionPage/pendingChanges.spec.tsx:16:38)
    at Object.<anonymous> (.../views/subscriptionPage/pendingChanges.spec.tsx:297:12)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
Subscription > PendingChanges renders plan and ondemand changes on different dates
Stack Traces | 0.014s run time 
TestingLibraryElementError: Unable to find an element with the text: (_, node) => node?.nodeName === 'LI' && node.textContent === text. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at getItemWithText (.../views/subscriptionPage/pendingChanges.spec.tsx:16:38)
    at Object.<anonymous> (.../views/subscriptionPage/pendingChanges.spec.tsx:352:12)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
Subscription > PendingChanges renders mm2 plan and ondemand changes
Stack Traces | 0.016s run time 
TestingLibraryElementError: Unable to find an element with the text: (_, node) => node?.nodeName === 'LI' && node.textContent === text. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at getItemWithText (.../views/subscriptionPage/pendingChanges.spec.tsx:16:38)
    at Object.<anonymous> (.../views/subscriptionPage/pendingChanges.spec.tsx:58:12)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@isabellaenriquez isabellaenriquez marked this pull request as ready for review April 1, 2025 16:15
@isabellaenriquez isabellaenriquez requested review from a team as code owners April 1, 2025 16:15
@isabellaenriquez isabellaenriquez merged commit a03c952 into master Apr 1, 2025
40 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/use-budget-term branch April 1, 2025 18:32
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@isabellaenriquez @andrewshie-sentry
chore(billing): Use budgetTerm (#88362)
1cec965 
Follow up to getsentry/getsentry#17051

This also updates over quota banner copy to be consistent across tiers
(if over quota and user has billing perms, the CTA pushes them to
setup/increase PAYG/OD). Prior to this PR, legacy customers would see
the copy "Increase Reserved Limits" or "Update Plan" which should've
taken them to checkout when it actually mistakenly took them to
subscription settings with the open OD modal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrettscott jarrettscott jarrettscott approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isabellaenriquez @jarrettscott