Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: remove unused SENTRY_PUBLIC / SENTRY_PUBLIC_ENDPOINT #88358

Merged
merged 1 commit into from
Apr 1, 2025
Merged

ref: remove unused SENTRY_PUBLIC / SENTRY_PUBLIC_ENDPOINT #88358

merged 1 commit into from
Apr 1, 2025

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested a review from a team March 31, 2025 17:34
@asottile-sentry asottile-sentry requested a review from a team as a code owner March 31, 2025 17:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 31, 2025
@asottile-sentry asottile-sentry force-pushed the asottile-remove-sentry-public branch from ffeff17 to 1da891e Compare March 31, 2025 17:57
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/models/projectkey.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #88358      +/-   ##
==========================================
- Coverage   87.72%   87.72%   -0.01%     
==========================================
  Files        9991     9991              
  Lines      565802   565790      -12     
  Branches    22253    22253              
==========================================
- Hits       496358   496342      -16     
- Misses      69021    69025       +4     
  Partials      423      423

@asottile-sentry asottile-sentry merged commit 6d9c2c9 into master Apr 1, 2025
48 checks passed
@asottile-sentry asottile-sentry deleted the asottile-remove-sentry-public branch April 1, 2025 14:30
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@asottile-sentry @andrewshie-sentry
ref: remove unused SENTRY_PUBLIC / SENTRY_PUBLIC_ENDPOINT (#88358)
3cdb35b 
<!-- Describe your PR here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarli joshuarli joshuarli approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asottile-sentry @joshuarli