chore(flags): rm autocomplete flag references in code #88354

michellewzhang · 2025-03-31T17:13:23Z

it's been rolled out to everyone for a while, so let's clean up this flag

options removal PR: https://github.com/getsentry/sentry-options-automator/pull/3427
unregister PR: chore(flags): unregister autcomplete flag #88344

codecov · 2025-03-31T17:17:32Z

❌ 9 Tests Failed:

Tests completed	Failed	Passed	Skipped
10051	9	10042	11

View the top 3 failed test(s) by shortest run time

WidgetBuilderSlideout passes undefined as the index for onSave if the index is not defined

Stack Traces | 0.175s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.



Error: No mocked response found for request: GET .../organizations/org-slug/tags/
    at recursivelyTraversePassiveMountEffects (.../react-dom/cjs/react-dom-client.development.js:12627:11)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:46:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

WidgetBuilderSlideout should not show the confirm modal if the widget is unsaved

Stack Traces | 0.213s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.



Error: No mocked response found for request: GET .../organizations/org-slug/tags/
    at recursivelyTraversePassiveMountEffects (.../react-dom/cjs/react-dom-client.development.js:12627:11)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:46:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

WidgetBuilderSlideout calls the save method with the index if it is defined

Stack Traces | 0.314s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.



Error: No mocked response found for request: GET .../organizations/org-slug/tags/
    at recursivelyTraversePassiveMountEffects (.../react-dom/cjs/react-dom-client.development.js:12627:11)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:46:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

it's been rolled out to everyone for a while, so let's clean up this flag - options removal PR: getsentry/sentry-options-automator#3427 - frontend removal PR: #88354

it's been rolled out to everyone for a while, so let's clean up this flag - options removal PR: getsentry/sentry-options-automator#3427 - unregister PR: #88344

it's been rolled out to everyone for a while, so let's clean up this flag - options removal PR: getsentry/sentry-options-automator#3427 - frontend removal PR: #88354

chore(flags): remove autocomplete flag references in code

3a1feb8

michellewzhang requested review from a team as code owners March 31, 2025 17:13

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2025

roggenkemper approved these changes Mar 31, 2025

View reviewed changes

michellewzhang mentioned this pull request Mar 31, 2025

chore(flags): unregister autcomplete flag #88344

Merged

vercel bot deployed to Preview March 31, 2025 17:20 View deployment

✅ fix tests

40804f3

michellewzhang requested a review from a team as a code owner March 31, 2025 17:24

michellewzhang requested a review from aliu39 March 31, 2025 17:24

vercel bot deployed to Preview March 31, 2025 17:28 View deployment

michellewzhang changed the title ~~chore(flags): remove autocomplete flag references in code~~ chore(flags): rm autocomplete flag references in code Mar 31, 2025

aliu39 approved these changes Apr 1, 2025

View reviewed changes

michellewzhang merged commit 0c14bf2 into master Apr 1, 2025
41 checks passed

michellewzhang deleted the mz/autocomplete-removal-fe branch April 1, 2025 17:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(flags): rm autocomplete flag references in code #88354

chore(flags): rm autocomplete flag references in code #88354

michellewzhang commented Mar 31, 2025

codecov bot commented Mar 31, 2025 •

edited

Loading

chore(flags): rm autocomplete flag references in code #88354

chore(flags): rm autocomplete flag references in code #88354

Conversation

michellewzhang commented Mar 31, 2025

codecov bot commented Mar 31, 2025 • edited Loading

❌ 9 Tests Failed:

codecov bot commented Mar 31, 2025 •

edited

Loading