chore(aci): add logging for plugin notifications #88342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrajjoshi
approved these changes
Mar 31, 2025
saponifi3d
reviewed
Mar 31, 2025
Comment on lines
+199
to
201
| self.logger.info("rules.plugin_notification_sent", extra=extra) | ||
|
|
||
| metrics.incr("notifications.sent", instance=plugin.slug, skip_internal=False) |
There was a problem hiding this comment.
can we use the metric that is being sent to verify the notifications instead of adding a log? is there additional data we should have on the metric to make it more useful?
There was a problem hiding this comment.
unfortunately not, since we need to be able to distinguish these notifications from the "Send notification to all legacy integrations" action (they use the same metric)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 31, 2025
add logging to verify that plugin notifications even work in the current world
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add logging to verify that plugin notifications even work in the current world