Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aci): more delayed workflow logs part 5 #88338

Merged
merged 4 commits into from
Mar 31, 2025

Conversation

cathteng
Copy link
Member

😭 just out here debugging

@cathteng cathteng requested a review from a team March 31, 2025 16:03
@cathteng cathteng requested a review from a team as a code owner March 31, 2025 16:03
@cathteng cathteng enabled auto-merge (squash) March 31, 2025 16:03
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 31, 2025
@saponifi3d
Copy link
Contributor

Is there a better way we can debug this than adding more logs? Could we gather data and reproduce issues locally? Is there a vercel instance we could use to debug?

@cathteng
Copy link
Member Author

@saponifi3d i'm trying to reproduce the issue locally to no avail, so something about my assumptions must be off. i am looking for the inputs into get_rules_to_fire because my local tests are saying that it SHOULD fire, but it is not in prod

@saponifi3d
Copy link
Contributor

cool, don't mean to block this PR, just wondering if there's a better way we can investigate this issue.

@cathteng cathteng merged commit 29cb554 into master Mar 31, 2025
47 checks passed
@cathteng cathteng deleted the cathy/aci/delayed-workflow-logs-5 branch March 31, 2025 16:55
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/rules/processing/delayed_processing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #88338       +/-   ##
===========================================
+ Coverage   45.51%   87.72%   +42.20%     
===========================================
  Files        9976     9992       +16     
  Lines      564635   565474      +839     
  Branches    22275    22275               
===========================================
+ Hits       256996   496037   +239041     
+ Misses     307217    69015   -238202     
  Partials      422      422               

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants