feat(taskworker): Make auth taskworker compatible #88336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88336 +/- ##
==========================================
- Coverage 87.73% 87.73% -0.01%
==========================================
Files 10008 10002 -6
Lines 566780 566570 -210
Branches 22271 22223 -48
==========================================
- Hits 497290 497088 -202
+ Misses 69071 69064 -7
+ Partials 419 418 -1 |
markstory
approved these changes
Apr 1, 2025
| @@ -0,0 +1,4 @@ | |||
| from sentry.taskworker.registry import TaskNamespace, taskregistry | |||
There was a problem hiding this comment.
We could move this file and the auth tasks to sentry.auth.tasks (can be done separately). That would avoid the duplicate segment in the import path.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this [document](https://www.notion.so/sentry/Rollout-Planning-1bd8b10e4b5d80aeaaa7dba0efca83bc). * Move `auth` and `check_auth` into `/auth` directory * Add auth namespaces and rollout options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is required to migrate tasks from celery to the new taskbroker system. The sentry option will be used to control the rollout of these tasks. The full migration plan is describe in this document.
authandcheck_authinto/authdirectory