Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ourlogs): Enable the sentry logger integration for sentry #88334

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

colin-sentry
Copy link
Member

This enables the new logging integration within Sentry itself, gated behind a rollout flag ourlogs.sentry-emit-rollout

@colin-sentry colin-sentry requested review from a team as code owners March 31, 2025 15:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 31, 2025
Copy link
Member

@k-fish k-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start the rollout very low (<0.001%) to ensure we don't have trouble, otherwise lgtm

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/utils/sdk.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88334      +/-   ##
==========================================
+ Coverage   87.72%   87.87%   +0.14%     
==========================================
  Files        9990    10007      +17     
  Lines      565278   569689    +4411     
  Branches    22277    22277              
==========================================
+ Hits       495895   500601    +4706     
+ Misses      68961    68666     -295     
  Partials      422      422              

@colin-sentry colin-sentry enabled auto-merge (squash) March 31, 2025 17:21
@colin-sentry colin-sentry merged commit fd5eb0f into master Mar 31, 2025
50 checks passed
@colin-sentry colin-sentry deleted the ourlogs_dogfood branch March 31, 2025 17:46
@colin-sentry colin-sentry restored the ourlogs_dogfood branch March 31, 2025 19:11
@colin-sentry colin-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Mar 31, 2025
@colin-sentry
Copy link
Member Author

reverting until the backend change is deployed for safety

@getsentry-bot
Copy link
Contributor

PR reverted: 10a856b

getsentry-bot added a commit that referenced this pull request Mar 31, 2025
andrewshie-sentry pushed a commit that referenced this pull request Mar 31, 2025
This enables the new `logging` integration within Sentry itself, gated
behind a rollout flag `ourlogs.sentry-emit-rollout`
andrewshie-sentry pushed a commit that referenced this pull request Mar 31, 2025
colin-sentry added a commit that referenced this pull request Mar 31, 2025
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants