-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ourlogs): Enable the sentry logger integration for sentry #88334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start the rollout very low (<0.001%) to ensure we don't have trouble, otherwise lgtm
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88334 +/- ##
==========================================
+ Coverage 87.72% 87.87% +0.14%
==========================================
Files 9990 10007 +17
Lines 565278 569689 +4411
Branches 22277 22277
==========================================
+ Hits 495895 500601 +4706
+ Misses 68961 68666 -295
Partials 422 422 |
reverting until the backend change is deployed for safety |
PR reverted: 10a856b |
#88334)" This reverts commit fd5eb0f. Co-authored-by: colin-sentry <[email protected]>
This enables the new `logging` integration within Sentry itself, gated behind a rollout flag `ourlogs.sentry-emit-rollout`
#88334)" This reverts commit fd5eb0f. Co-authored-by: colin-sentry <[email protected]>
This enables the new
logging
integration within Sentry itself, gated behind a rollout flagourlogs.sentry-emit-rollout