Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)default-windows-wizard-install #88326

Merged
merged 4 commits into from
Apr 1, 2025

Conversation

smeubank
Copy link
Member

@smeubank smeubank commented Mar 31, 2025

Move logic for checking user agent from selecting auto vs default to selecting the windows tab for the wizard install

edit: adding this change to other onboardings for mobile too. Especially for react-native this default to manual made no sense. RN devs will use npx regardless of OS

image

Move logic for checking user agent from selecting auto vs default to selecting the windows tab for the wizard install
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2025
@smeubank smeubank marked this pull request as ready for review April 1, 2025 08:56
@smeubank smeubank requested a review from a team as a code owner April 1, 2025 08:56
smeubank added 2 commits April 1, 2025 11:31
adding this to other onboardings for mobile. Especially for react-native this default to manual made no sense. RN devs will use npx regardless of OS
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@smeubank smeubank merged commit fef9d08 into master Apr 1, 2025
42 checks passed
@smeubank smeubank deleted the (feat)default-windows-wizard-install branch April 1, 2025 14:04
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Move logic for checking user agent from selecting auto vs default to
selecting the windows tab for the wizard install

edit: adding this change to other onboardings for mobile too. Especially
for react-native this default to manual made no sense. RN devs will use
npx regardless of OS

<img width="1408" alt="image"
src="https://github.com/user-attachments/assets/518aee56-f008-4ae8-b295-172e5a5e20d6"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants