feat(billing): Subscription page updates for categories with 0 reserved #88288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide-included-count
dashed
approved these changes
Mar 31, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 31, 2025
…ed (#88288) Closes: getsentry/getsentry#17043 Some data categories do not have the ability to reserve quota, and are handled as on-demand/pay-as-you go only. This PR clarifies the subscription page for this group of data categories. ### Description Some information on the subscription page is misleading because profile duration categories do not support reserved quota. Removes the subtext describing the reserved quota count (always "0 Reserved"). Also removes the "Included in Subscription", which calculates the usage total compared to the reserved quota. ### Before <img width="1203" alt="Screenshot 2025-03-28 at 9 46 20 AM" src="https://github.com/user-attachments/assets/414a4cde-4418-4611-b5c1-327dcef99e4f" /> ### After <img width="1176" alt="Screenshot 2025-03-28 at 5 18 45 PM" src="https://github.com/user-attachments/assets/d28fad22-9465-44ab-bd12-5124b39caf94" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/getsentry/getsentry/issues/17043
Some data categories do not have the ability to reserve quota, and are handled as on-demand/pay-as-you go only. This PR clarifies the subscription page for this group of data categories.
Description
Some information on the subscription page is misleading because profile duration categories do not support reserved quota.
Removes the subtext describing the reserved quota count (always "0 Reserved"). Also removes the "Included in Subscription", which calculates the usage total compared to the reserved quota.
Before
After