feat(org member invite): OrganizationMemberInviteDetails GET endpoint #88283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mifu67
commented
Mar 28, 2025
| @@ -74,22 +73,6 @@ | |||
| """ | |||
|
|
|||
|
|
|||
| class RelaxedMemberPermission(OrganizationPermission): | |||
There was a problem hiding this comment.
Moved this to ./organization_member/utils.py
cathteng
approved these changes
Mar 28, 2025
| "GET": ApiPublishStatus.EXPERIMENTAL, | ||
| "PUT": ApiPublishStatus.EXPERIMENTAL, | ||
| } | ||
| owner = ApiOwner.ENTERPRISE |
There was a problem hiding this comment.
i think ecosystem / whatever the new name of the team is is owning auth, but can fix later
| "PUT": ["member:invite", "member:write", "member:admin"], | ||
| # DELETE checks for role comparison as you can either remove a member | ||
| # with a lower access role, or yourself, without having the req. scope | ||
| "DELETE": ["member:read", "member:write", "member:admin"], |
There was a problem hiding this comment.
for later: we should probably allow deleting an invite/request if the requesting user was the inviter, regardless of scopes
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88283 +/- ##
===========================================
+ Coverage 42.13% 87.73% +45.60%
===========================================
Files 9969 10002 +33
Lines 564906 566605 +1699
Branches 22255 22255
===========================================
+ Hits 238002 497095 +259093
+ Misses 326486 69092 -257394
Partials 418 418 |
Base automatically changed from
mifu67/member-invite/org-member-invite-index
to
master
March 31, 2025 21:19
c786c65 to
0627867
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…#88283) The `OrganizationMemberDetails` endpoint also adds lists of serialized team roles and organization roles to the GET response. Talked with @leedongwei: it is not clear why this is necessary, so we decided not to add these fields to the new endpoint. In particular, `allowed_roles = get_allowed_org_roles(request, organization, member)` gets the roles that the _member_ would be allowed to assign when inviting a user to the organization. This only really makes sense when `member` is the requesting user themself, which isn't possible for an invited organization member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OrganizationMemberDetailsendpoint also adds lists of serialized team roles and organization roles to the GET response. Talked with @leedongwei: it is not clear why this is necessary, so we decided not to add these fields to the new endpoint.In particular,
allowed_roles = get_allowed_org_roles(request, organization, member)gets the roles that the member would be allowed to assign when inviting a user to the organization. This only really makes sense whenmemberis the requesting user themself, which isn't possible for an invited organization member.