fix(autofix): Remove animations when navigating, handle comment popup overlap #88275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
reviewed
Mar 28, 2025
Comment on lines
182
to
194
| const hasRootCauseStep = steps.some( | ||
| step => step.type === AutofixStepType.ROOT_CAUSE_ANALYSIS | ||
| ); | ||
| const hasSolutionStep = steps.some(step => step.type === AutofixStepType.SOLUTION); | ||
| const hasChangesStep = steps.some(step => step.type === AutofixStepType.CHANGES); | ||
|
|
||
| const isRootCauseFirstAppearance = hasRootCauseStep && !previousRootCauseRef.current; | ||
| const isSolutionFirstAppearance = hasSolutionStep && !previousSolutionRef.current; | ||
| const isChangesFirstAppearance = hasChangesStep && !previousChangesRef.current; | ||
|
|
||
| previousRootCauseRef.current = hasRootCauseStep; | ||
| previousSolutionRef.current = hasSolutionStep; | ||
| previousChangesRef.current = hasChangesStep; |
There was a problem hiding this comment.
can't we achieve the same but in a much simpler way by just maintaining an isMounted (or something similar if we need to wait for data to load) state for the whole drawer/all the steps, and anything that appears after initial mount is just considered that step being polled in?
jennmueng
reviewed
Mar 31, 2025
Comment on lines
+339
to
+350
| const previousInsightsRef = useRef<AutofixInsight[]>([]); | ||
| const [newInsightIndices, setNewInsightIndices] = useState<number[]>([]); | ||
|
|
||
| // Compare current insights with previous insights to determine which ones are new | ||
| useEffect(() => { | ||
| if (insights.length === previousInsightsRef.current.length + 1) { | ||
| setNewInsightIndices([insights.length - 1]); | ||
| } else { | ||
| setNewInsightIndices([]); | ||
| } | ||
| previousInsightsRef.current = [...insights]; | ||
| }, [insights]); |
There was a problem hiding this comment.
is it possible to use the isMounted implementation for insight cards too?
There was a problem hiding this comment.
It becomes more complex because that doesn't cover the expanding/collapsing of the insight card section, which doesn't cause a re-mount. For that to work, I have to track that state too, and then it's more complex than the current approach @jennmueng
jennmueng
approved these changes
Mar 31, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
… overlap (#88275) Remove animations when opening drawer and expanding insight section. Also increase clarity of which comment thread is focused when there are multiple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove animations when opening drawer and expanding insight section. Also increase clarity of which comment thread is focused when there are multiple.