ref(eap): useServiceEntrySpans code flow #88262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjq
approved these changes
Mar 31, 2025
| @@ -82,9 +193,7 @@ export function useServiceEntrySpansQuery({ | |||
| cursor, | |||
| pageFilters: selection, | |||
| // This query does not apply when the Recent option is selected | |||
There was a problem hiding this comment.
nit: this comment can probably be deleted now (it's far enough away from the logic that it's a bit confusing)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 31, 2025
Iterates on #87923 by breaking up the logical flow of this hook into two separate hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterates on #87923 by breaking up the logical flow of this hook into two separate hooks