fix(top-events): Handle values better in top events #88249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Mar 28, 2025
- When using the table values in a top events query we use the top event values as part of the stats query. But if that value has anything we perceive as a wildcard we then escape it mistakenly
- This makes it so when we're doing this we directly pass the value back into the filter without any modification
- When using the table values in a top events query we use the top event
values as part of the stats query. But if that value has anything we
perceive as a wildcard we then escape it mistakenly
- This makes it so when we're doing this we directly pass the value
back into the filter without any modification
Zylphrex
approved these changes
Mar 31, 2025
shruthilayaj
approved these changes
Mar 31, 2025
Comment on lines
+445
to
+447
| # If we're using the raw value only it'll never be a wildcard | ||
| if self.use_raw_value: | ||
| return False |
There was a problem hiding this comment.
do you need this here if we're already skipping the is_wildcard check here? https://github.com/getsentry/sentry/pull/88249/files#diff-0b239bf9fccf786d1ac7bd5498e7133b828157098100ba72ceae29b2254ca915R423-R424
There was a problem hiding this comment.
Good q, There are checks elsewhere in the code for SearchValue.is_wildcard that we need to be False so we need it in both locations.
It's a bit weird cause it feels like this check here makes 423 unnecessary too, but since the raw_value is a string we need the check in both methods
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 31, 2025
- When using the table values in a top events query we use the top event values as part of the stats query. But if that value has anything we perceive as a wildcard we then escape it mistakenly - This makes it so when we're doing this we directly pass the value back into the filter without any modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.