-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eap-spans): update web vitals functions for eap #88242
Merged
DominikB2014
merged 5 commits into
master
from
dominikbuszowiecki/dain-132-update-web-vitals-score-functions
Apr 3, 2025
Merged
fix(eap-spans): update web vitals functions for eap #88242
DominikB2014
merged 5 commits into
master
from
dominikbuszowiecki/dain-132-update-web-vitals-score-functions
Apr 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88242 +/- ##
===========================================
+ Coverage 42.14% 87.79% +45.65%
===========================================
Files 9976 10007 +31
Lines 565125 566679 +1554
Branches 22267 22210 -57
===========================================
+ Hits 238153 497504 +259351
+ Misses 326554 68741 -257813
- Partials 418 434 +16 |
…als-score-functions
edwardgou-sentry
approved these changes
Apr 2, 2025
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
total_opportunity_score
function, replace withopportunity_score(measurement.score.total)
opportunity_score
to normalize from (0-1) on the backendtotal_opportunity_score
to be