-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eap-spans): update span-samples endpoint to use rpc #88234
Merged
DominikB2014
merged 10 commits into
master
from
dominikbuszowiecki/dain-100-update-spans-sample-endpoint-to-query-eap
Apr 3, 2025
Merged
feat(eap-spans): update span-samples endpoint to use rpc #88234
DominikB2014
merged 10 commits into
master
from
dominikbuszowiecki/dain-100-update-spans-sample-endpoint-to-query-eap
Apr 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88234 +/- ##
==========================================
- Coverage 87.74% 87.73% -0.01%
==========================================
Files 10050 10026 -24
Lines 568481 568364 -117
Branches 22322 22289 -33
==========================================
- Hits 498786 498646 -140
+ Misses 69316 69283 -33
- Partials 379 435 +56 |
…ample-endpoint-to-query-eap
wmak
approved these changes
Apr 3, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
1. When the query param `useRpc` equals to `1`, the `spans-sample` endpoint will query for spans from the eap dataset via the rpc 2. Adds the `bounded_sample` function In future iterations, we'll try to make this more random, but this will serve us well for testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useRpc
equals to1
, thespans-sample
endpoint will query for spans from the eap dataset via the rpcbounded_sample
functionIn future iterations, we'll try to make this more random, but this will serve us well for testing purposes.