Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eap-spans): update span-samples endpoint to use rpc #88234

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Mar 28, 2025

  1. When the query param useRpc equals to 1, the spans-sample endpoint will query for spans from the eap dataset via the rpc
  2. Adds the bounded_sample function

In future iterations, we'll try to make this more random, but this will serve us well for testing purposes.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 18 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/sentry/api/endpoints/organization_events_meta.py 72.58% 17 Missing ⚠️
src/sentry/search/eap/spans/aggregates.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88234      +/-   ##
==========================================
- Coverage   87.74%   87.73%   -0.01%     
==========================================
  Files       10050    10026      -24     
  Lines      568481   568364     -117     
  Branches    22322    22289      -33     
==========================================
- Hits       498786   498646     -140     
+ Misses      69316    69283      -33     
- Partials      379      435      +56     

@DominikB2014 DominikB2014 marked this pull request as ready for review March 28, 2025 21:04
@DominikB2014 DominikB2014 requested a review from a team as a code owner March 28, 2025 21:04
@DominikB2014 DominikB2014 merged commit b48314d into master Apr 3, 2025
48 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-100-update-spans-sample-endpoint-to-query-eap branch April 3, 2025 20:32
Copy link

sentry-io bot commented Apr 4, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: invalid literal for int() with base 10: '466.66666666666663' /api/0/organizations/{organization_id_or_slug}/... View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
1. When the query param `useRpc` equals to `1`, the `spans-sample`
endpoint will query for spans from the eap dataset via the rpc
2. Adds the `bounded_sample` function

In future iterations, we'll try to make this more random, but this will
serve us well for testing purposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants