Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove BitbucketMixin #88228

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

asottile-sentry
Copy link
Member

not really saving any code duplication -- and the type checker hated it

not really saving any code duplication -- and the type checker hated it
@asottile-sentry asottile-sentry requested review from a team March 28, 2025 17:15
@asottile-sentry asottile-sentry requested review from a team as code owners March 28, 2025 17:15
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/sentry_plugins/bitbucket/repository_provider.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #88228   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files        9988     9987    -1     
  Lines      565070   565115   +45     
  Branches    22289    22289           
=======================================
+ Hits       495629   495674   +45     
  Misses      69006    69006           
  Partials      435      435           

@asottile-sentry asottile-sentry merged commit 4208cee into master Mar 31, 2025
49 checks passed
@asottile-sentry asottile-sentry deleted the asottile-typing-bitbucket-mixin branch March 31, 2025 14:21
andrewshie-sentry pushed a commit that referenced this pull request Mar 31, 2025
not really saving any code duplication -- and the type checker hated it

<!-- Describe your PR here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants