🔧 chore(sentry apps): remove sentry_app auto disable #88216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88216 +/- ##
==========================================
+ Coverage 87.72% 87.74% +0.02%
==========================================
Files 9980 10017 +37
Lines 564755 567546 +2791
Branches 22235 22235
==========================================
+ Hits 495414 497977 +2563
- Misses 68925 69153 +228
Partials 416 416 |
GabeVillalobos
approved these changes
Apr 1, 2025
| @@ -63,7 +63,14 @@ def record_response_for_disabling_integration(response: SlackResponse, integrati | |||
| if is_response_error(response): | |||
| buffer.record_error() | |||
| if buffer.is_integration_broken(): | |||
| disable_integration(buffer, redis_key, integration_id) | |||
| # disable_integration(buffer, redis_key, integration_id) | |||
There was a problem hiding this comment.
Mark this with a todo to remove in the future.
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
This feature is buggy and doesn't use the organization_service to fetch an org. from previous change to disable other parts of this feature > We've seen two reported cases where this is not behaving as expected. Here, i disable the feature and add logging incase we want to investigate this apps in the future continues #73295 fixes https://sentry.sentry.io/issues/6383663640/
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This feature is buggy and doesn't use the organization_service to fetch an org. from previous change to disable other parts of this feature > We've seen two reported cases where this is not behaving as expected. Here, i disable the feature and add logging incase we want to investigate this apps in the future continues #73295 fixes https://sentry.sentry.io/issues/6383663640/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is buggy and doesn't use the organization_service to fetch an org.
from previous change to disable other parts of this feature
Here, i disable the feature and add logging incase we want to investigate this apps in the future
continues #73295
fixes https://sentry.sentry.io/issues/6383663640/