Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix typing for organization_alert_rule_index #88210

Merged

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team March 28, 2025 16:10
@asottile-sentry asottile-sentry requested review from a team as code owners March 28, 2025 16:10
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 28, 2025
@@ -1853,7 +1852,6 @@ def get_slack_actions_with_async_lookups(
context={
"organization": organization,
"access": SystemAccess(),
"user": user,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to be completely unused -- I couldn't find anything in the output that relied on it 🤷

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...cidents/endpoints/organization_alert_rule_index.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #88210       +/-   ##
===========================================
+ Coverage   42.13%   87.72%   +45.58%     
===========================================
  Files        9960     9994       +34     
  Lines      564217   565838     +1621     
  Branches    22253    22261        +8     
===========================================
+ Hits       237745   496363   +258618     
+ Misses     326049    69050   -256999     
- Partials      423      425        +2     

@asottile-sentry asottile-sentry merged commit e4b7073 into master Apr 3, 2025
48 checks passed
@asottile-sentry asottile-sentry deleted the asottile-typing-organization-alert-rule-index branch April 3, 2025 15:20
adrian-codecov pushed a commit that referenced this pull request Apr 3, 2025
Copy link

sentry-io bot commented Apr 8, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: OperationalError('server closed the connection unexpectedly\n\tThis probably means the server terminated abnormally\n\tbefore or while processing the request.\n') /api/0/organizations/{organization_id_or_slug}/... View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants