feat(eap-spans): implement time_spent_percentage
#88117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmak
reviewed
Mar 27, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88117 +/- ##
===========================================
+ Coverage 42.15% 87.72% +45.56%
===========================================
Files 9962 9994 +32
Lines 564080 565788 +1708
Branches 22269 22269
===========================================
+ Hits 237807 496353 +258546
+ Misses 325851 69013 -256838
Partials 422 422 |
wmak
reviewed
Mar 31, 2025
…spent_percentage-function
wmak
reviewed
Mar 31, 2025
| @@ -235,6 +235,8 @@ class FunctionDefinition: | |||
| extrapolation: bool = True | |||
| # Processor is the function run in the post process step to transform a row into the final result | |||
| processor: Callable[[Any], Any] | None = None | |||
| # returns true if the function should be enabled for the given request else returns false with a reason why it is not enabled | |||
| check_if_enabled: Callable[[SnubaParams], tuple[bool, str]] | None = None | |||
There was a problem hiding this comment.
Could we follow the pattern from QueryBuilders?
- Add
privatehere - In the
SearchResolverConfigadd afunctions_acl - Table queries get
SearchResolverConfig(functions_acl=["time_spent_percentage"])
There was a problem hiding this comment.
I like that suggestion, makes more sense to gate this at the time of the resolver instantiation versus in the resolver as we know if it will be a timeseries request by that point
wmak
approved these changes
Mar 31, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 31, 2025
DominikB2014
added a commit
that referenced
this pull request
Apr 1, 2025
Add `functions_acl` and replace `FunctionDefinition.check_if_enabled` as discussed in #88117
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Add `functions_acl` and replace `FunctionDefinition.check_if_enabled` as discussed in #88117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/getsentry/eap-planning/issues/162