-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(alerts): add issue_type tag to notifications.sent metric #88063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, you could also include the type
here if you need to know the specific issue type, rather than the broad category.. I don't think it really adds too much cardinality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
In DD, this will allow us to aggregate by the [GroupType](https://github.com/getsentry/sentry/blob/5510957c4ed7d7ad50f60b34d425c618cd15dd08/src/sentry/issues/grouptype.py#L155) of issue alerts. We'll get counts for specific types and can create detectors for them Note: we'll have to enable aggregation for this specific tag in DD, which will add some cost. There's a fixed number of group types defined in grouptype.py.
In DD, this will allow us to aggregate by the GroupType of issue alerts. We'll get counts for specific types and can create detectors for them
Note: we'll have to enable aggregation for this specific tag in DD, which will add some cost. There's a fixed number of group types defined in grouptype.py.