Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(alerts): add issue_type tag to notifications.sent metric #88063

Merged
merged 6 commits into from
Apr 3, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 27, 2025

In DD, this will allow us to aggregate by the GroupType of issue alerts. We'll get counts for specific types and can create detectors for them

Note: we'll have to enable aggregation for this specific tag in DD, which will add some cost. There's a fixed number of group types defined in grouptype.py.

@aliu39 aliu39 requested review from a team as code owners March 27, 2025 06:02
@aliu39 aliu39 requested review from JoshFerge and ceorourke March 27, 2025 06:03
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2025
@aliu39 aliu39 requested a review from a team March 27, 2025 18:12
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you could also include the type here if you need to know the specific issue type, rather than the broad category.. I don't think it really adds too much cardinality

@aliu39 aliu39 changed the title ref(alerts): add group_category tag to notifications.sent metric ref(alerts): add issue_type tag to notifications.sent metric Apr 2, 2025
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliu39 aliu39 merged commit f6d6ec1 into master Apr 3, 2025
50 checks passed
@aliu39 aliu39 deleted the aliu/alert-metric branch April 3, 2025 18:16
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
In DD, this will allow us to aggregate by the
[GroupType](https://github.com/getsentry/sentry/blob/5510957c4ed7d7ad50f60b34d425c618cd15dd08/src/sentry/issues/grouptype.py#L155)
of issue alerts. We'll get counts for specific types and can create
detectors for them

Note: we'll have to enable aggregation for this specific tag in DD,
which will add some cost. There's a fixed number of group types defined
in grouptype.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants