feat(trace-eap-waterfall): Rendering errors associated with spans #88060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardgou-sentry
approved these changes
Mar 28, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…8060) The goal of this PR is to only render error markers for errors that ARE correlated with a span in the trace. Will put up a separate PR to render orphan errors in the waterfall. To summarize the changes, we added a new `EAPError` type and added `errors: EAPError[]` to `EAPSpan` type. Added tests <img width="1254" alt="Screenshot 2025-03-27 at 2 26 53 PM" src="https://github.com/user-attachments/assets/d4bd0d15-8f54-47dc-8d0a-fb68ef48adbf" /> --------- Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to only render error markers for errors that ARE correlated with a span in the trace.
Will put up a separate PR to render orphan errors in the waterfall.
To summarize the changes, we added a new
EAPErrortype and addederrors: EAPError[]toEAPSpantype.Added tests