ref: Streamline loading replays for hydration diffs in Issue Details #88028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
scttcper
reviewed
Mar 26, 2025
Comment on lines
33
to
44
| function wrapInSection(render: () => ReactNode) { | ||
| return function () { | ||
| return ( | ||
| <InterimSection | ||
| type={SectionKey.HYDRATION_DIFF} | ||
| title={t('Hydration Error Diff')} | ||
| > | ||
| {render()} | ||
| </InterimSection> | ||
| ); | ||
| }; | ||
| } |
There was a problem hiding this comment.
just pull this out into a component with children?
There was a problem hiding this comment.
@scttcper it gets formatted out to more line if it's a React component :(
billyvg
approved these changes
Mar 27, 2025
| return ( | ||
| <Fragment> | ||
| {input} | ||
| {render(replaySlug)} |
There was a problem hiding this comment.
imo it's kind of confusing to have two different rendering methods in this component -- I don't really know how they're used but what if they were two components ReplaySlugChooser and ReplaySlugChooserWithLoaderStuff
There was a problem hiding this comment.
i'll pass back over this chooser and clean it up.
it's used by some /stories/ files so people can load up real reply data and see the video components working together, so the two interfaces kind of optimize for keeping the stories readable right now.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 31, 2025
…88028) Before we had two 'placeholder' thing that would render while we wait for the hydration diff preview to load up: - A `<LoadingIndicator />` while we're lazy-loading the `replayDiffContent.tsx` file - Then `<Placeholder/>` while we load the replay data over ajax This resulted in janky loading swapping one placeholder for another. Also, we weren't properly handling all loading states before, so if the replay was missing or archived it looked janky. Now that `<ReplayLoadingState>` is in place, all cases are handled. For example: | Before | After | | --- | --- | | <img width="846" alt="SCR-20250326-mjkc" src="https://github.com/user-attachments/assets/68053fcf-5a2d-44aa-850f-f85255e5526e" /> | <img width="841" alt="SCR-20250326-mjmr" src="https://github.com/user-attachments/assets/c7ffbbcc-9193-46ea-8f37-1df3e4245dac" /> | Along the way i changed the interface to the new `<ReplayLoadingState>`. Now it takes the result of `useLoadReplayReader` as a prop. This will make it possible to separate loading and rendering, so we can deal with logging that sometimes happens, or in the case of Traces, the loading happens very far away and props get drilled down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we had two 'placeholder' thing that would render while we wait for the hydration diff preview to load up:
<LoadingIndicator />while we're lazy-loading thereplayDiffContent.tsxfile<Placeholder/>while we load the replay data over ajaxThis resulted in janky loading swapping one placeholder for another.
Also, we weren't properly handling all loading states before, so if the replay was missing or archived it looked janky. Now that
<ReplayLoadingState>is in place, all cases are handled. For example:Along the way i changed the interface to the new
<ReplayLoadingState>. Now it takes the result ofuseLoadReplayReaderas a prop. This will make it possible to separate loading and rendering, so we can deal with logging that sometimes happens, or in the case of Traces, the loading happens very far away and props get drilled down.