feat(eap): Add downsampling to the api #88023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Mar 26, 2025
- This updates the events/ api to accept a sampling param so we can make a preflight before trying the new best_effort
- Tests are not really ready, but opening this for now so FE can start sorta testing at least
- This updates the events/ api to accept a sampling param so we can make a preflight before trying the new best_effort - Tests are not really ready, but opening this for now so FE can start sorta testing at least
narsaynorath
approved these changes
Mar 26, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88023 +/- ##
===========================================
+ Coverage 42.13% 87.77% +45.64%
===========================================
Files 9961 9995 +34
Lines 564258 565304 +1046
Branches 22256 22203 -53
===========================================
+ Hits 237768 496223 +258455
+ Misses 326067 68647 -257420
- Partials 423 434 +11 |
Zylphrex
reviewed
Mar 31, 2025
| @@ -298,6 +300,7 @@ def run_top_events_timeseries_query( | |||
| limit, | |||
| referrer, | |||
| config, | |||
| None, | |||
There was a problem hiding this comment.
Is this intentional set to none for the top events timeseries? And the sampling mode be implemented for any timeseries queries?
There was a problem hiding this comment.
Yeah, was trying to rush this out originally and only do it for /events/, i'll follow up with stats
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 31, 2025
- This updates the events/ api to accept a sampling param so we can make a preflight before trying the new best_effort - Tests are not really ready, but opening this for now so FE can start sorta testing at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.