ref(feedback): clean up search suggestion fields #87949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
reviewed
Mar 27, 2025
billyvg
approved these changes
Apr 1, 2025
aliu39
added a commit
that referenced
this pull request
Apr 1, 2025
5 tasks
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
`contact_email` `name` These are not valid search fields for /issues/. They were probably derived from the feedback context object. We have `user.email` and `user.username` instead `message` This is valid but you have to search for the whole msg, not a substring. Case and whitespace sensitive. IMO this is not a useful search, and suggestions are polluted by issue platform error messages and confusing:  `transaction` This is a valid search for the `transaction` tag, however we don't include the tag in ingestion. So unless it's a custom tag attached by the sender, IMO we shouldn't suggest it. The suggestions for these are also from IP: <img width="564" alt="Screenshot 2025-03-26 at 10 50 29 AM" src="https://github.com/user-attachments/assets/fbfad771-179d-49a3-b9a8-a6065b4aa547" />
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contact_emailnameThese are not valid search fields for /issues/. They were probably derived from the feedback context object. We have
user.emailanduser.usernameinsteadmessageThis is valid but you have to search for the whole msg, not a substring. Case and whitespace sensitive. IMO this is not a useful search, and suggestions are polluted by issue platform error messages and confusing:
transactionThis is a valid search for the
transactiontag, however we don't include the tag in ingestion. So unless it's a custom tag attached by the sender, IMO we shouldn't suggest it. The suggestions for these are also from IP: