Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(flags): improve text wrapping on view all tags button #87806

Merged
merged 6 commits into from
Apr 1, 2025
Merged

style(flags): improve text wrapping on view all tags button #87806

merged 6 commits into from
Apr 1, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 24, 2025 •
edited by ryan953
Loading

Using non-breaking space unicode: stack overflow

After Only Tags:
Screenshot 2025-03-24 at 2 47 07 PM

After Tags & FF:
Screenshot 2025-03-24 at 2 46 28 PM

Before:
Screenshot 2025-03-24 at 2 49 46 PM

@aliu39 aliu39 requested a review from a team as a code owner March 24, 2025 21:49
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 24, 2025
@aliu39 aliu39 requested a review from a team March 24, 2025 21:50
@aliu39 aliu39 enabled auto-merge (squash) March 24, 2025 21:51
@aliu39 aliu39 disabled auto-merge March 24, 2025 21:52
@aliu39 aliu39 enabled auto-merge (squash) March 24, 2025 21:53
roggenkemper
roggenkemper reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@roggenkemper roggenkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have design approval on this? i personally think this looks worse than it did before

@aliu39 aliu39 disabled auto-merge March 24, 2025 21:53
@aliu39
Copy link
Member Author

aliu39 commented Mar 24, 2025

do we have design approval on this? i personally think this looks worse than it did before

discussing in https://sentry.slack.com/archives/C07GR2V2CH4/p1742848562863439

@ryan953
Copy link
Member

ryan953 commented Mar 31, 2025

Added some tweaks per discussion here: https://sentry.slack.com/archives/C07GR2V2CH4/p1742848562863439

@aliu39 aliu39 merged commit 80b4117 into master Apr 1, 2025
40 checks passed
@aliu39 aliu39 deleted the aliu/view-all-flags-style branch April 1, 2025 18:28
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@aliu39 @ryan953 @andrewshie-sentry
style(flags): improve text wrapping on view all tags button (#87806)
aa1f39f 
Using non-breaking space unicode: [stack
overflow](https://stackoverflow.com/questions/37909134/nbsp-jsx-not-working/37909363#37909363)

**After Only Tags:**
![Screenshot 2025-03-24 at 2 47
07 PM](https://github.com/user-attachments/assets/cde2edcb-4ff4-405a-b313-bb061355ba64)

**After Tags & FF:**
![Screenshot 2025-03-24 at 2 46
28 PM](https://github.com/user-attachments/assets/d545f423-9670-4b18-8284-a19d6e943242)

**Before:**
![Screenshot 2025-03-24 at 2 49
46 PM](https://github.com/user-attachments/assets/87df2654-fce2-4f5f-8b90-0976ad0e27f4)

---------

Co-authored-by: Ryan Albrecht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan953 ryan953 ryan953 approved these changes

@roggenkemper roggenkemper roggenkemper left review comments

@michellewzhang michellewzhang michellewzhang left review comments

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliu39 @ryan953 @roggenkemper @michellewzhang