Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of .signature() and .s() #88088

Closed
markstory opened this issue Mar 27, 2025 · 0 comments
Closed

Replace usage of .signature() and .s() #88088

markstory opened this issue Mar 27, 2025 · 0 comments
Assignees
@markstory

Comments

@markstory
Copy link
Member

We have a few usages of Task.signature() and Task.s(). These methods aren't supported by taskworker, and we should replace the current usage with either direct calls to .delay() or wrap methods with lambda to ease integration with transaction.on_commit().

Impacted callsites

  • src/sentry/profiles/consumers/process/factory.py : 18
  • src/sentry/incidents/subscription_processor.py : 790
  • src/sentry/incidents/logic.py : 1163
@markstory markstory self-assigned this Apr 1, 2025
markstory added a commit that referenced this issue Apr 1, 2025
@markstory
fix(taskworker) Remove usage of Task.signature() and Task.s()
76a7bf1 
Remove usage of these celery features as we don't have them implemented
in taskbroker, and given the number and kind of usage these methods are
getting we've decided to not implement them for taskworkers.

Refs #88088
@markstory markstory mentioned this issue Apr 1, 2025
Merged
markstory added a commit that referenced this issue Apr 3, 2025
@markstory
fix(taskworker) Remove usage of Task.signature() and Task.s() (#88480)
b85814a 
Remove usage of these celery features where we don't need to be using
them.

Refs #88088
adrian-codecov pushed a commit that referenced this issue Apr 3, 2025
@markstory @adrian-codecov
fix(taskworker) Remove usage of Task.signature() and Task.s() (#88480)
07c79e9 
Remove usage of these celery features where we don't need to be using
them.

Refs #88088
andrewshie-sentry pushed a commit that referenced this issue Apr 8, 2025
@markstory @andrewshie-sentry
fix(taskworker) Remove usage of Task.signature() and Task.s() (#88480)
6a4b09b 
Remove usage of these celery features where we don't need to be using
them.

Refs #88088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markstory markstory

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markstory