fix(taskworker) Remove usage of Task.signature() and Task.s() #88480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of these celery features as we don't have them implemented in taskbroker, and given the number and kind of usage these methods are getting we've decided to not implement them for taskworkers. Refs #88088
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88480 +/- ##
===========================================
+ Coverage 56.29% 87.75% +31.45%
===========================================
Files 10001 10011 +10
Lines 566436 567351 +915
Branches 22270 22270
===========================================
+ Hits 318860 497862 +179002
+ Misses 247157 69070 -178087
Partials 419 419 |
We can't use lambda in a loop because closures retain the last value.
Introduce an intermediary function to solve lambdas closing over incorrect loop values.
markstory
commented
Apr 2, 2025
Comment on lines
+1170
to
+1176
| def _schedule_trigger_action( | ||
| action_id: int, incident_id: int, project_id: int, method: str, new_status: int | ||
| ) -> None: | ||
| from sentry.incidents.tasks import handle_trigger_action | ||
|
|
||
| transaction.on_commit( | ||
| lambda: handle_trigger_action.delay( |
There was a problem hiding this comment.
I don't love these additional values, but lambda defined in a loop end up closing over the last iteration item, and the additional function layer ensures that the lambda closes over the correct value.
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
Remove usage of these celery features where we don't need to be using them. Refs #88088
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Remove usage of these celery features where we don't need to be using them. Refs #88088
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of these celery features where we don't need to be using them.
Refs #88088