fix(github): Use pull_request_target for changelog preview on fork PRs #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2ba794 to
f9d81f3
Compare
Contributor
|
The changelog-preview workflow failed with HTTP 403 when trying to post comments on PRs from forks because the pull_request event provides a read-only GITHUB_TOKEN for security reasons. Switch to pull_request_target which runs in the base repo context with write permissions. This requires explicitly specifying the PR merge ref for checkout since pull_request_target defaults to the base branch. This is safe because the workflow only reads git metadata and config - no PR code is executed (Craft binary comes from releases).
f9d81f3 to
499b4cc
Compare
betegon
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes changelog-preview workflow failing with HTTP 403 on PRs from forks.
Problem: The
pull_requestevent provides a read-onlyGITHUB_TOKENfor fork PRs (security measure), preventing the workflow from posting comments.Solution: Switch to
pull_request_targetwhich runs in the base repository context with write permissions.Changes
pull_requesttopull_request_targetrefto checkout step (required becausepull_request_targetdefaults to base branch)pull_request_targetSecurity
This is safe because:
.craft.ymlconfig are read