Skip to content

Comments

[ENH] Add group_by parameter to structural_elements_from_borehole_set and plotting improvements#1025

Merged
Leguark merged 5 commits intomainfrom
changes_while_prob
May 10, 2025
Merged

[ENH] Add group_by parameter to structural_elements_from_borehole_set and plotting improvements#1025
Leguark merged 5 commits intomainfrom
changes_while_prob

Conversation

@Leguark
Copy link
Member

@Leguark Leguark commented May 10, 2025

Description

Added support for grouping boreholes by different criteria in the structural_elements_from_borehole_set function by adding a group_by parameter with options 'component lith' or 'lith_ids' (default). Also improved type hinting in the Grid class for active_grids property and added visualization code for contour plotting with custom color levels in the activator functions test module.

Relates to #undefined

Checklist

  • My code uses type hinting for function and method arguments and return values.
  • I have created tests which cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New tests pass locally with my changes.

Leguark added 4 commits May 9, 2025 16:01
Added type hints to `active_grids` getter and setter, improving code readability and enabling better type checking. This enhancement ensures consistency in type usage for the `active_grids` property.
Introduce a `group_by` parameter with `Literal` typing in `structural_elements_from_borehole_set` for flexible grouping. Also, add dotenv initialization in the example script to manage environment variables.
Copy link
Member Author

Leguark commented May 10, 2025

@Leguark Leguark changed the title [ENH] Add type hints to active_grids property in grid.py [ENH] Add group_by parameter to structural_elements_from_borehole_set and plotting improvements May 10, 2025
@Leguark Leguark marked this pull request as ready for review May 10, 2025 10:52
@graphite-app graphite-app bot added the gempy 3 Will come with the next major update label May 10, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 10, 2025

Graphite Automations

"Add gempy label" took an action on this PR • (05/10/25)

1 label was added to this PR based on Miguel de la Varga's automation.

Copy link
Member Author

Leguark commented May 10, 2025

Merge activity

  • May 10, 7:15 AM EDT: A user started a stack merge that includes this pull request via Graphite.

@Leguark Leguark merged commit 61b804b into main May 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gempy 3 Will come with the next major update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant